Force openfoam only use Opt build type#3591
Force openfoam only use Opt build type#3591appolloford wants to merge 1 commit intoeasybuilders:developfrom
Conversation
|
Not much description here. I'm guessing this is to make it consistent with the meaning of "debug" in toolchain options? I.e. debug is supposed to mean only debug symbols, not a debug build. Ideally, the easyblock should respect lowopt/noopt options that should reflect a debug type build scenario, though i suppoe the old code in the easyblock didn't do that either? |
| self.build_type = 'Debug' | ||
| else: | ||
| self.build_type = 'Opt' | ||
| # Always set build type to Opt, let easybuild decide CFLAGS and CXXFLAGS |
There was a problem hiding this comment.
Hmm, I don't see a need for this, especially in EasyBuild 5.0 where we have a global setting to determine the value of the debug toolchain option (which is disabled by default).
What's the motivation for this exactly?
There was a problem hiding this comment.
if self.toolchain.options['debug']:
self.build_type = 'Debug'
is just wrong logic. self.toolchain.options['debug'] means "enable_debug_symbols"
if self.toolchain.options['noopt']:
self.build_type = 'Debug'
would be appropriate.
|
Since EB5 uses debug symbol in toolchains by default. The original OpenFOAM easyblock captures the value and sets the build type to 'debug' and use the build-in debug flags such as the c++Debug file: I think here are two problems:
To summary, the PR would like to force EB always use Opt case as this is the only one which passes the EB environment variables into their wmake in current openfoam easyblock |
|
@appolloford I changed to target branch in this PR from |
|
I don't think anything in this PR is affected by the synchronization. |
3 participants
(created using
eb --new-pr)